Fix configure.ac : unused command line argument triggers erros #214
Conversation
|
Hm, this option was added in clang 3.1, but as expected earlier versions didn't raise a warning if its |
|
For some reason, I was under the impression this option also existed under GCC, but now I can't find any info supporting this. I'll adjust accordingly. Envoyé depuis mon appareil Galaxy
-------- Message d'origine --------De : Simon Sobisch ***@***.***> Date : 10/02/2025 20:31 (GMT+01:00) À : OCamlPro/gnucobol ***@***.***> Cc : OCP David Declerck ***@***.***>, Author ***@***.***> Objet : Re: [OCamlPro/gnucobol] Fix configure.ac : unused command line argument triggers erros (PR #214)
Hm, this option was added in clang 3.1, but as expected earlier versions didn't raise a warning if its Wno form is used.
It still should not be applied to GCC, but only to clang. So maybe set it directly after recognizing clang?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I've just asked gcc by adding |
ddeclerck
force-pushed
the
fix_unused_command_args
branch
from
e5568c4 to
6d65085
Compare
|
Updated to apply the change only to Clang. Now for some reason (unrelated to this PR), the MSYS2 CI stopped working, complaining it can not find tex... That might be because the Windows runner image has been updated since last CI run... I guess I'll have to tackle this in another PR... |
|
Can't you pin (back) the windows runner image so updating it is a manual procedure (instead of the need to potentially fix it whenever it is updated)? |
ddeclerck
force-pushed
the
fix_unused_command_args
branch
from
6d65085 to
bdecde0
Compare
Seems GitHub Actions does not allow that (cf actions/runner#3447)... |
There was a problem hiding this comment.
this is nearly ready for SVN - when you check that into upstream, please add a note to the Changelog as well providing the reasoning to add this option (no need to update this PR; also the CI definition here can be kept for now until that file is adjusted later - we can directly do that in the 4.x CI one, which will be rebased after this change and the init_fileio fix are merged upstream)
As mentionned in a previous comment, unused arguments trigger errors in the configure script :
This makes detection of some features (
-fstack-clash-protectionon macOS) fail even if they are available.This is even worst in 4.x (in the yet-to-be-merged batch), as it fails to detect "gcc pointer sign", which causes many testsuite failures.
This PR simply adds
-Wno-unused-command-line-argumentto the CFLAGS under gcc and Clang (and removes if from the CI workflow). Not sure if this should come earlier in the configure file ?Should be merged in 4.x once upstream in 3.x.